fix(plugin-koa): Ensure unhandled Koa errors are logged out #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
approved these changes
Aug 16, 2019
bengourley
commented
Aug 16, 2019
| // this function will throw if you give it a non-error, but we still want | ||
| // to output that, so if it throws, pass it back what it threw (a TypeError) | ||
| ctx.app.onerror(err) | ||
| } catch (e) { |
There was a problem hiding this comment.
tomlongridge
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our plugin adds an
"onerror"handler to the Koa app, which stops the default from being called.The default error handler which prints the error is available at
ctx.app.onerrorso by calling through to that after notifying, it exhibits the default behaviour.Tested manually with
notifyReleaseStagesboth allowing and preventing delivery and added a unit test to ensure the original handler is called.Output before:
Output after:
Fixes #602